Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 655ee4d2796c44db41552773349f7cd950fcca56
https://github.com/WebKit/WebKit/commit/655ee4d2796c44db41552773349f7cd950fcca56
Author: Mike Wyrzykowski <[email protected]>
Date: 2025-03-04 (Tue, 04 Mar 2025)
Changed paths:
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
Log Message:
-----------
[WebGPU] Shader validation routines potentially rely on UB in C++
https://bugs.webkit.org/show_bug.cgi?id=288726
rdar://145760120
Reviewed by Cameron McCormack.
The shader was using a buffer of sizeof(S) + sizeof(uint)
and writing to &S::lastUintMember + 1 assuming it would
write to the uint.
This is flagged by sanitizers, so be explict and define
the member we are writing to.
* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::Buffer):
(WebGPU::Buffer::makeIndexIndirectBuffer): Deleted.
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::checkForIndirectDrawDeviceLost):
Canonical link: https://commits.webkit.org/291576@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
