Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b4d27c3a21dab43e99a8c79d24a59aed7c0761e4
https://github.com/WebKit/WebKit/commit/b4d27c3a21dab43e99a8c79d24a59aed7c0761e4
Author: Luke Warlow <[email protected]>
Date: 2025-03-12 (Wed, 12 Mar 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/input-type-popovertarget-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-behavior-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-reflection-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-behavior-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-reflection-expected.txt
M Source/WebCore/html/HTMLButtonElement.cpp
M Source/WebCore/html/HTMLButtonElement.h
M Source/WebCore/html/HTMLInputElement.cpp
Log Message:
-----------
Update button activation and reflection behavior with command or commandfor
https://bugs.webkit.org/show_bug.cgi?id=287288
Reviewed by Anne van Kesteren.
This patch correctly updates the button activation steps to match the spec,
missing and invalid type buttons no longer submit forms when they have a
command or commandfor
attribute. They also correctly don't act as command buttons.
This patch also updates form associated reset buttons and inputs to not trigger
popovertarget or commandfor behavior.
The button elements type reflection also correctly reflects as button
when it has a missing or invalid type attribute and has command or commandfor.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/input-type-popovertarget-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-behavior-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-reflection-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-behavior-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-type-reflection-expected.txt:
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::attributeChanged):
(WebCore::HTMLButtonElement::defaultEventHandler):
(WebCore::HTMLButtonElement::computeType):
* Source/WebCore/html/HTMLButtonElement.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
Canonical link: https://commits.webkit.org/292010@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
