Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 641e3471af50f360b35fc1a02febabbea56c1213
      
https://github.com/WebKit/WebKit/commit/641e3471af50f360b35fc1a02febabbea56c1213
  Author: David Quesada <david_ques...@apple.com>
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm

  Log Message:
  -----------
  -[WKWebView closeAllMediaPresentationsWithCompletionHandler:] has a nullable 
completion handler, but crashes if it's nil
https://bugs.webkit.org/show_bug.cgi?id=290196
rdar://108514148

Reviewed by Richard Robinson.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView closeAllMediaPresentationsWithCompletionHandler:]):
    Handle the case where the completion handler is null, which is allowable, 
per the
    nullability annotation in the header.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
(TEST(WKWebViewCloseAllMediaPresentations, NilCompletionHandler)):

Canonical link: https://commits.webkit.org/292520@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to