Title: [112460] trunk/Source/_javascript_Core
Revision
112460
Author
[email protected]
Date
2012-03-28 15:43:04 -0700 (Wed, 28 Mar 2012)

Log Message

Build fix - some compiles generating NORETURN related warnings.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112459 => 112460)


--- trunk/Source/_javascript_Core/ChangeLog	2012-03-28 22:34:08 UTC (rev 112459)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-28 22:43:04 UTC (rev 112460)
@@ -1,3 +1,12 @@
+2012-03-28  Gavin Barraclough  <[email protected]>
+
+        Build fix - some compiles generating NORETURN related warnings.
+
+        * yarr/YarrJIT.cpp:
+        (JSC::Yarr::YarrGenerator::setSubpatternStart):
+        (JSC::Yarr::YarrGenerator::setSubpatternEnd):
+        (JSC::Yarr::YarrGenerator::clearSubpatternStart):
+
 2012-03-28  Kevin Ollivier  <[email protected]>
 
         [wx] Unreviewed. Build fix, move WTF back into JSCore target

Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (112459 => 112460)


--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2012-03-28 22:34:08 UTC (rev 112459)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2012-03-28 22:43:04 UTC (rev 112460)
@@ -328,19 +328,19 @@
     void setSubpatternStart(RegisterID reg, unsigned subpattern)
     {
         ASSERT(subpattern);
-        ASSERT(compileMode == IncludeSubpatterns);
+        // FIXME: should be able to ASSERT(compileMode == IncludeSubpatterns), but then this function is conditionally NORETURN. :-(
         store32(reg, Address(output, (subpattern << 1) * sizeof(int)));
     }
     void setSubpatternEnd(RegisterID reg, unsigned subpattern)
     {
         ASSERT(subpattern);
-        ASSERT(compileMode == IncludeSubpatterns);
+        // FIXME: should be able to ASSERT(compileMode == IncludeSubpatterns), but then this function is conditionally NORETURN. :-(
         store32(reg, Address(output, ((subpattern << 1) + 1) * sizeof(int)));
     }
     void clearSubpatternStart(unsigned subpattern)
     {
         ASSERT(subpattern);
-        ASSERT(compileMode == IncludeSubpatterns);
+        // FIXME: should be able to ASSERT(compileMode == IncludeSubpatterns), but then this function is conditionally NORETURN. :-(
         store32(TrustedImm32(-1), Address(output, (subpattern << 1) * sizeof(int)));
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to