Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bd20485fedcd7603fded7c7f2eb011738d61e8d9
https://github.com/WebKit/WebKit/commit/bd20485fedcd7603fded7c7f2eb011738d61e8d9
Author: Chris Dumez <[email protected]>
Date: 2025-04-02 (Wed, 02 Apr 2025)
Changed paths:
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
Log Message:
-----------
http/tests/security/wrong-global-object-after-javascript-url.html hits an
assertion
https://bugs.webkit.org/show_bug.cgi?id=290774
rdar://148121607
Reviewed by Alan Baradlay.
We were hitting the following assertion in
`WebLocalFrameLoaderClient::dispatchDidReachLayoutMilestone()`:
```
ASSERT(!m_frame->isMainFrame() ||
webPage->corePage()->settings().suppressesIncrementalRendering() ||
m_didCompletePageTransition);
```
This basically means that we're sending a layout milestone notification even
though `m_didCompletePageTransition`
is false. `m_didCompletePageTransition` is set to false during the early page
load to avoid flashing white content
on navigation.
To address the issue, update
LocalFrameView::fireLayoutRelatedMilestonesIfNeeded() to ask the client if we
should
suppress layout milestones or not.
* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fireLayoutRelatedMilestonesIfNeeded):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:
Canonical link: https://commits.webkit.org/293120@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
