Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fe228e0d18f6e639bec1187ea8aba2395b5f3168
https://github.com/WebKit/WebKit/commit/fe228e0d18f6e639bec1187ea8aba2395b5f3168
Author: Brent Fulgham <[email protected]>
Date: 2025-04-02 (Wed, 02 Apr 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/Cairo.cmake
M Source/WebCore/platform/Skia.cmake
M Source/WebCore/platform/graphics/ComplexTextController.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
A Source/WebCore/platform/graphics/FontCascadeInlines.h
M Source/WebCore/platform/graphics/WidthIterator.cpp
M Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp
A Source/WebCore/platform/graphics/cairo/FontCascadeCairoInlines.h
R Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.cpp
A Source/WebCore/platform/graphics/cocoa/FontCascadeCocoaInlines.h
M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp
A Source/WebCore/platform/graphics/skia/FontCascadeSkiaInlines.h
A Source/WebCore/platform/graphics/win/FontCascadeWinInlines.h
M Source/WebCore/platform/graphics/win/FontWin.cpp
Log Message:
-----------
Minor cleanups identified during review of ComplexTextController
https://bugs.webkit.org/show_bug.cgi?id=290114
rdar://147517437
Reviewed by Sammy Gill.
This patch marks a few always-constant methods as contexpr, and corrects the
move handling
in the FontPlatformData constructor for Cocoa types.
* Source/WebCore/Headers.cmake: Add new files
* Source/WebCore/SourcesCocoa.txt: Ditto
* Source/WebCore/WebCore.xcodeproj/project.pbxproj: Ditto
* Source/WebCore/platform/Cairo.cmake: Ditto
* Source/WebCore/platform/Skia.cmake: Ditto
* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::enclosingGlyphBoundsForTextRun): Reorder
conditional to check bool variable
before function call.
* Source/WebCore/platform/graphics/ComplexTextController.h:
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::width const): Use constexpr for compile-time constant.
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/FontCascadeInlines.h: Added.
* Source/WebCore/platform/graphics/WidthIterator.cpp: Add new include.
* Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::canReturnFallbackFontsForComplexText): Deleted.
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText): Deleted.
* Source/WebCore/platform/graphics/cairo/FontCascadeCairoInlines.h: Copied from
Source/WebCore/platform/graphics/win/FontWin.cpp.
(WebCore::FontCascade::canReturnFallbackFontsForComplexText):
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText):
* Source/WebCore/platform/graphics/cocoa/FontCascadeCocoaInlines.h: Renamed
from Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.cpp.
(WebCore::FontCascade::canReturnFallbackFontsForComplexText):
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText):
* Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::computeOverallTextMatrix):
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformData::FontPlatformData): Use proper move semantics in
constructor.
* Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp:
(WebCore::FontCascade::canReturnFallbackFontsForComplexText): Deleted.
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText): Deleted.
* Source/WebCore/platform/graphics/skia/FontCascadeSkiaInlines.h: Copied from
Source/WebCore/platform/graphics/win/FontWin.cpp.
(WebCore::FontCascade::canReturnFallbackFontsForComplexText):
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText):
* Source/WebCore/platform/graphics/win/FontCascadeWinInlines.h: Copied from
Source/WebCore/platform/graphics/win/FontWin.cpp.
(WebCore::FontCascade::canReturnFallbackFontsForComplexText):
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText):
* Source/WebCore/platform/graphics/win/FontWin.cpp:
(WebCore::FontCascade::canReturnFallbackFontsForComplexText): Deleted.
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText): Deleted.
Canonical link: https://commits.webkit.org/293130@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
