Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a16768b5797d97d57c56a47466d6abc6c060a177
      
https://github.com/WebKit/WebKit/commit/a16768b5797d97d57c56a47466d6abc6c060a177
  Author: Tadeu Zagallo <tzaga...@apple.com>
  Date:   2025-04-03 (Thu, 03 Apr 2025)

  Changed paths:
    M LayoutTests/fast/webgpu/array-length-pointer-parameter-expected.txt
    M LayoutTests/fast/webgpu/array-length-pointer-parameter.html
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/array-length-pointer2.wgsl
    M Source/WebGPU/WGSL/tests/struct-errors.wgsl

  Log Message:
  -----------
  [WGSL] Structs containing runtime-sized arrays should not be nested
https://bugs.webkit.org/show_bug.cgi?id=290937
rdar://148035899

Reviewed by Mike Wyrzykowski.

The spec[1] says that all struct members should either have creation-fixed
footprint or the last member may be a runtime-sized array. However, a struct
that contains a runtime-sized array doesn't have creation-fixed footprint,
so it can't be used as a member of another struct.

[1]: https://www.w3.org/TR/WGSL/#struct-types

* LayoutTests/fast/webgpu/array-length-pointer-parameter-expected.txt:
* LayoutTests/fast/webgpu/array-length-pointer-parameter.html:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/struct.wgsl:
* Source/WebGPU/WGSL/tests/valid/array-length-pointer2.wgsl:

Canonical link: https://commits.webkit.org/293151@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to