Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07b6563676a6e6c20485d3e3a875bf985178b560
https://github.com/WebKit/WebKit/commit/07b6563676a6e6c20485d3e3a875bf985178b560
Author: Devin Rousso <[email protected]>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css
M Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
Log Message:
-----------
Web Inspector: REGRESSION(289844@main): virtualized `WI.TreeOutline` can
sometimes jump around
https://bugs.webkit.org/show_bug.cgi?id=290031
Reviewed by BJ Burg.
* Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .scroll-container):
(.open-resource-dialog > .scroll-container > .virtualized-spacer): Added.
The `offsetParent` is not the same thing as `parentNode`. Mark the parent as
`position: relative` to make it qualify.
Ensure that the spacers before and after the `WI.TreeOutline` do not shrink
since the `offsetParent` is `display: flex;`.
* Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.registerScrollVirtualizer):
(WI.TreeOutline.prototype._updateVirtualizedElements):
(WI.TreeOutline.prototype._updateVirtualizedElements.walk): Deleted.
Rework the math to calculate what `WI.TreeElement` should be attached to or
removed from the DOM to lower the chance of errors by basing the spacer heights
on what's actually in the DOM.
Drive-by: leverage `WI.TreeElement.prototype.traverseNextTreeElement` instead
of having custom tree walking logic.
Canonical link: https://commits.webkit.org/292455@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
