Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1730f65980c9f1e1f31ecc0a17f667258f4dd066
https://github.com/WebKit/WebKit/commit/1730f65980c9f1e1f31ecc0a17f667258f4dd066
Author: Pascoe <[email protected]>
Date: 2025-04-04 (Fri, 04 Apr 2025)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/AppSSOSPI.h
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h
M
Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm
Log Message:
-----------
AppSSO should not hang the main thread
rdar://133093114
https://bugs.webkit.org/show_bug.cgi?id=290656
Reviewed by Charlie Wolfe and Ben Nham.
AppSSO currently performs a sync call that ends up hanging the main thread.
We have been provided equivalent SPI that does not hang the main thread, this
patch moves to using that.
Updated API test infrastructure and all existing tests pass.
* Source/WebCore/PAL/pal/spi/cocoa/AppSSOSPI.h:
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h:
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm:
(WebKit::SOAuthorizationCoordinator::canAuthorize):
(WebKit::SOAuthorizationCoordinator::tryAuthorize):
(WebKit::SOAuthorizationCoordinator::canAuthorize const): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm:
(overrideCanPerformAuthorizationWithURL):
(TestWebKitAPI::TEST(SOAuthorizationRedirect, InterceptionError)):
Canonical link: https://commits.webkit.org/293270@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
