Title: [112502] trunk/Source/WebCore
- Revision
- 112502
- Author
- [email protected]
- Date
- 2012-03-28 22:47:18 -0700 (Wed, 28 Mar 2012)
Log Message
Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=82442
Patch by Vineet Chaudhary <[email protected]> on 2012-03-28
Reviewed by Kentaro Hara.
No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
even after these changes.
* testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.
(WebCore::JSInternals::userPreferredLanguages):
* testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.
(WebCore::V8Internals::userPreferredLanguagesAccessorGetter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112501 => 112502)
--- trunk/Source/WebCore/ChangeLog 2012-03-29 05:29:47 UTC (rev 112501)
+++ trunk/Source/WebCore/ChangeLog 2012-03-29 05:47:18 UTC (rev 112502)
@@ -1,3 +1,18 @@
+2012-03-28 Vineet Chaudhary <[email protected]>
+
+ Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=82442
+
+ Reviewed by Kentaro Hara.
+
+ No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
+ even after these changes.
+
+ * testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.
+ (WebCore::JSInternals::userPreferredLanguages):
+ * testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.
+ (WebCore::V8Internals::userPreferredLanguagesAccessorGetter):
+
2012-03-28 Hayato Ito <[email protected]>
Let focus navigation be compliant with Shadow DOM spec.
Modified: trunk/Source/WebCore/testing/js/JSInternalsCustom.cpp (112501 => 112502)
--- trunk/Source/WebCore/testing/js/JSInternalsCustom.cpp 2012-03-29 05:29:47 UTC (rev 112501)
+++ trunk/Source/WebCore/testing/js/JSInternalsCustom.cpp 2012-03-29 05:47:18 UTC (rev 112502)
@@ -36,8 +36,6 @@
{
Internals* imp = static_cast<Internals*>(impl());
const Vector<String> languages = imp->userPreferredLanguages();
- if (languages.isEmpty())
- return jsNull();
MarkedArgumentBuffer array;
Vector<String>::const_iterator end = languages.end();
Modified: trunk/Source/WebCore/testing/v8/V8InternalsCustom.cpp (112501 => 112502)
--- trunk/Source/WebCore/testing/v8/V8InternalsCustom.cpp 2012-03-29 05:29:47 UTC (rev 112501)
+++ trunk/Source/WebCore/testing/v8/V8InternalsCustom.cpp 2012-03-29 05:47:18 UTC (rev 112502)
@@ -35,8 +35,6 @@
{
Internals* internals = V8Internals::toNative(info.Holder());
const Vector<String> languages = internals->userPreferredLanguages();
- if (languages.isEmpty())
- return v8::Null();
v8::Local<v8::Array> array = v8::Array::New(languages.size());
Vector<String>::const_iterator end = languages.end();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
