Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c7d162471fe7409fe86633378797ae2816b5dbaf
https://github.com/WebKit/WebKit/commit/c7d162471fe7409fe86633378797ae2816b5dbaf
Author: Alex Christensen <[email protected]>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/scrolling/ScrollingCoordinator.h
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
Log Message:
-----------
Remove ScrollingCoordinator::willDestroyScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=289929
rdar://147249739
Reviewed by Charlie Wolfe.
The virtual function call doesn't do anything, but it does cause occasional
crashes on teardown.
Remove it to improve performance and decrease our crash rate. No change in
behavior.
Also make RenderLayerCompositor::scrollingCoordinator more robust to teardown.
rdar://145408212
contains a crash from its use of RenderView::page during teardown that we can
avoid. If there
is no scrolling coordinator, there is nothing to tear down.
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::willDetachPage):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::prepareForDetach):
* Source/WebCore/page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::willDestroyScrollableArea): Deleted.
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::clear):
Canonical link: https://commits.webkit.org/292293@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
