Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 29376ef30d5c94725e3832096d3812e1ce368d32
https://github.com/WebKit/WebKit/commit/29376ef30d5c94725e3832096d3812e1ce368d32
Author: Tadeu Zagallo <[email protected]>
Date: 2025-04-03 (Thu, 03 Apr 2025)
Changed paths:
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
A Source/WebGPU/WGSL/tests/minus-minus-ambiguity.wgsl
Log Message:
-----------
[WGSL] Resolve ambiguities in parsing minus minus tokens
https://bugs.webkit.org/show_bug.cgi?id=290939
rdar://148323248
Reviewed by Mike Wyrzykowski.
During lexing we combine `--` into a `MinusMinus` token, but we might need to
split
it into two `Minus` tokens during parsing. e.g. `1 -- 1` should be parsed as
`1 - (-1)`.
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::Lexer<T>::lex):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::splitMinusMinus):
(WGSL::Parser<Lexer>::canBeginUnaryExpression):
(WGSL::Parser<Lexer>::canContinueAdditiveExpression):
(WGSL::canBeginUnaryExpression): Deleted.
(WGSL::canContinueAdditiveExpression): Deleted.
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/tests/minus-minus-ambiguity.wgsl: Added.
Canonical link: https://commits.webkit.org/293150@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
