Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 82dbbc0e5f2e5563ea511d3d26722d8a1a09e9d9
https://github.com/WebKit/WebKit/commit/82dbbc0e5f2e5563ea511d3d26722d8a1a09e9d9
Author: Estevan Castilho <[email protected]>
Date: 2025-04-05 (Sat, 05 Apr 2025)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
Fix cross-axis extent calculation for alignment baselines lying outside of
the flex item
https://bugs.webkit.org/show_bug.cgi?id=290968
Reviewed by Alan Baradlay.
Initialize maxDescent to LayoutUnit::min() rather than 0, such that
the cross-axis extent for a baseline-aligned flex item still gets
calculated correctly even when the maximum descent results in a
negative value (say, because the baseline lies outside of the flex
item's boundaries).
This is a fix imported from Chromium[1], based on a comment[2] under
WebKit/WebKit#31376.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/5901280
[2]: https://github.com/WebKit/WebKit/pull/31376#discussion_r1782062028
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceFlexItems):
Initialize maxDescent to LayoutUnit::min() rather than 0, as to
properly take negative descent values into account when calculating
the cross-axis extent for baseline-aligned items.
* LayoutTests/TestExpectations:
Remove expected failure for
imported/w3c/web-platform-tests/css/css-flexbox/baseline-outside-flex-item.html
Canonical link: https://commits.webkit.org/293305@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
