Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a025bc40ba4754766f3949c823bb88a3c42bc029
https://github.com/WebKit/WebKit/commit/a025bc40ba4754766f3949c823bb88a3c42bc029
Author: Lily Spiniolas <lily_spinio...@apple.com>
Date: 2025-04-17 (Thu, 17 Apr 2025)
Changed paths:
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/Platform/mac/MenuUtilities.mm
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
Update context menu images for internal clients
https://bugs.webkit.org/show_bug.cgi?id=291707
rdar://149504756
Reviewed by Abrar Rahman Protyasha.
Updated context menu images for internal clients
where needed, including removing unneeded ones.
The UnifiedPDF item which opened the PDF in an external
viewer now displays the name of the default viewer rather
than always displaying "Preview". When context menu images
for internal clients is enabled, the image for this item
is set to the icon of the default PDF viewer.
In the "Font" submenu, the separator between "Styles..." and
"Show Color" has been moved above the "Outline" item, and
a new separator has been placed above the "Bold" item. This
results in a visually distinct section for the 3 checkable items
(Bold, Italic, Underline).
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createAndAppendFontSubMenu):
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemPDFOpenWithDefaultViewer):
(WebCore::contextMenuItemPDFOpenWithPreview): Deleted.
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/Platform/mac/MenuUtilities.mm:
(WebKit::symbolNameForAction):
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::getContextMenuItem):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::contextMenuActionFromTag const):
(WebKit::UnifiedPDFPlugin::toContextMenuItemTag):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::titleForContextMenuItemTag const):
(WebKit::UnifiedPDFPlugin::contextMenuItem const):
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
Canonical link: https://commits.webkit.org/293840@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
