Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 396567b4c760b73d9d3d518614044374d2665eba
https://github.com/WebKit/WebKit/commit/396567b4c760b73d9d3d518614044374d2665eba
Author: Tyler Wilcock <tyle...@apple.com>
Date: 2025-04-29 (Tue, 29 Apr 2025)
Changed paths:
A LayoutTests/accessibility/mac/menu-parameterized-attributes-expected.txt
A LayoutTests/accessibility/mac/menu-parameterized-attributes.html
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: VoiceOver skips over menu items with standard navigation commands in
Safari
https://bugs.webkit.org/show_bug.cgi?id=292292
rdar://150307176
Reviewed by Joshua Hoffman.
This happened because -[WebAccessibilityObjectWrapperMac
accessibilityParameterizedAttributeNames] was hardcoded to
return nil for menu-related items. Critically, this told VoiceOver that they
didn't support AXUIElementsForSearchPredicate,
so VoiceOver fell back to its own internal navigation algorithm, which was
insufficient. This behavior was added in
this commit for no discernible reason (no layout test, code comment, or commit
message explains it):
https://github.com/WebKit/WebKit/commit/5c40ab534bafebec6395542cc2808a8f7c023c72
Fix this by making menu-related items support the standard set of parameterized
attributes like everything else.
* LayoutTests/accessibility/mac/menu-parameterized-attributes-expected.txt:
Added.
* LayoutTests/accessibility/mac/menu-parameterized-attributes.html: Added.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
Canonical link: https://commits.webkit.org/294313@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
