Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6eb2b6af4dd8b9c0bd8810a7f6c1dd7e9dc24583 https://github.com/WebKit/WebKit/commit/6eb2b6af4dd8b9c0bd8810a7f6c1dd7e9dc24583 Author: rahimabdi <abdi.abdira...@gmail.com> Date: 2025-04-30 (Wed, 30 Apr 2025)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_heading.tentative-expected.txt M LayoutTests/platform/ios/accessibility/dialog-slotted-content-expected.txt M Source/WebCore/accessibility/AXCoreObject.cpp M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h Log Message: ----------- AX: Implement nameFrom: heading https://bugs.webkit.org/show_bug.cgi?id=257186 rdar://109700680 Reviewed by Tyler Wilcock. This PR adds a nameFrom: heading fallback for determining the accessible name of dialog, alert dialog and article elements. In the absence of a name that has been provided by an author or by content, a name may be derived for these elements using a depth-first search for a descendant heading element node (using the existing DOM descendantsOfType<> iterator). This PR also adds an additional AccessibilityTextSource::Heading for label type categorization and to facilitate accessibility logging. * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_heading.tentative-expected.txt: Updated due to PR. * LayoutTests/platform/ios/accessibility/dialog-slotted-content-expected.txt: Updated due to new test expectation. Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::AXCoreObject::isVisibleText): (WebCore::AXCoreObject::isDescriptiveText): (WebCore::AXCoreObject::descriptionAttributeValue() const): (WebCore::AXCoreObject::titleAttributeValue() const): Source/WebCore/accessibility/AXCoreObject.h: (WebCore::AXCoreObject::AccessibilityTextSource): * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::AXLogger::TextStream& operator): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::alternativeText const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibleNameDerivesFromHeading() const): * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibleNameDerivesFromHeading() const): Canonical link: https://commits.webkit.org/294335@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes