Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a0cbe308d311966582b5bc3333637b3b007e642
https://github.com/WebKit/WebKit/commit/9a0cbe308d311966582b5bc3333637b3b007e642
Author: Jer Noble <[email protected]>
Date: 2025-05-08 (Thu, 08 May 2025)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp
Log Message:
-----------
[visionOS] Spatial HLS playback not staying in spatial mode while seeking
rdar://146978728
https://bugs.webkit.org/show_bug.cgi?id=292737
Reviewed by Eric Carlson.
During a seek operation, an AVURLAsset backed by a HLS stream will tear down all
its AVPlayerItemTracks/AVAssetTracks and re-create those tracks once the seek
completes. During this tear-down, the old AVAssetTracks will sometimes "lose"
their CMFormatDescriptions as reported by AVAssetTrack.formatDescriptions. When
this happens, WebKit will report that the AVAssetTrack is no longer spatial.
(In addition, the track will no longer have a codec, nor a width or height.)
To work around this behavior, inside both AudioTrackPrivateAVFObjC and
VideoTrackPrivateAVFObjC, change the behavior of resetPropertiesFromTrack() to
skip updating the VideoTrackPrivate's configuration in the case where the old
configuration had a codec, but the new configuration does not. This prevents
the behavior where the track's internal objects are torn down from affecting
the clients of VideoTrackPrivateAVFObjC.
*
Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
*
Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack):
Canonical link: https://commits.webkit.org/294687@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
