Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4899869f41a1fec52533fee1db89628b891f8dc9 https://github.com/WebKit/WebKit/commit/4899869f41a1fec52533fee1db89628b891f8dc9 Author: Alex Christensen <achristen...@apple.com> Date: 2025-05-12 (Mon, 12 May 2025)
Changed paths: M Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp M Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h Log Message: ----------- DigitalCredentialsCoordinator should unregister its message receiver in its destructor https://bugs.webkit.org/show_bug.cgi?id=292872 rdar://151155753 Reviewed by Pascoe and Charlie Wolfe. In 294746@main we added a message registration but not a message unregistration, and that imbalance causes assertions when running tests on platforms where HAVE_DIGITAL_CREDENTIALS_UI is 1, such as TestWebKitAPI.SOAuthorizationPopUp.InterceptionSucceedCloseByItself. * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp: (WebKit::DigitalCredentialsCoordinator::DigitalCredentialsCoordinator): (WebKit::DigitalCredentialsCoordinator::~DigitalCredentialsCoordinator): * Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h: Canonical link: https://commits.webkit.org/294796@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes