Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58dae86e4a988e51738d9d1115e6ddd5266707fa
https://github.com/WebKit/WebKit/commit/58dae86e4a988e51738d9d1115e6ddd5266707fa
Author: Philippe Normand <ph...@igalia.com>
Date: 2025-05-14 (Wed, 14 May 2025)
Changed paths:
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
Log Message:
-----------
[GStreamer][MediaStream] Reference cycle in webkitmediastreamsrc preventing
its disposal
https://bugs.webkit.org/show_bug.cgi?id=292924
Reviewed by Xabier Rodriguez-Calvar.
The src pad probe data storing a strong reference of the src element introduced
a reference cycle,
so use a weak reference instead.
Also, remove a useless refcount increment/decrement in
webkitMediaStreamSrcEnsureStreamCollectionPosted, the callOnMainThreadAndWait
call is blocking so
there is no need to increase the element refcount before calling the closure.
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcEnsureStreamCollectionPosted):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcAddTrack):
Canonical link: https://commits.webkit.org/294886@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
