Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84e85f84be9c1913afc0222aae54a7b0fad53c48 https://github.com/WebKit/WebKit/commit/84e85f84be9c1913afc0222aae54a7b0fad53c48 Author: Brent Fulgham <bfulg...@apple.com> Date: 2025-05-14 (Wed, 14 May 2025)
Changed paths: M Source/WTF/wtf/LogChannels.cpp M Source/WTF/wtf/LogChannels.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/history/HistoryItem.cpp M Source/WebCore/history/HistoryItem.h M Source/WebCore/loader/FormSubmission.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/HistoryController.cpp M Source/WebCore/loader/NavigationScheduler.cpp M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/RemoteFrame.h M Source/WebCore/platform/ContextMenuItem.h M Source/WebCore/platform/PasteboardCustomData.h M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp M Source/WebCore/xml/DOMParser.cpp M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/ModelProcess/ModelProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/Shared/AuxiliaryProcess.cpp M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.h M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.mm M Source/WebKit/Shared/SessionState.cpp M Source/WebKit/Shared/SessionState.h M Source/WebKit/UIProcess/API/APIWebsitePolicies.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.cpp M Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.h M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp Log Message: ----------- WebKit should provide a move option for setting custom user agent (and other things) https://bugs.webkit.org/show_bug.cgi?id=291285 rdar://148857394 Reviewed by Geoffrey Garen. While working on Bug 291113 I realized that DocumentLoader and RemoteFrame do not provide a move overload, even though they are often populated with the result of a new temporary string. We could avoid copying a non-trivial string in a few places by correcting this. I also noticed a few similar patterns and added Move operators for them. * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/loader/DocumentLoader.h: (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::clientRedirectSourceForHistory const): (WebCore::DocumentLoader::setClientRedirectSourceForHistory): (WebCore::DocumentLoader::serverRedirectDestinationForHistory const): (WebCore::DocumentLoader::setCustomUserAgent): * Source/WebCore/loader/FrameLoadRequest.cpp: (WebCore::FrameLoadRequest::FrameLoadRequest): * Source/WebCore/loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::setClientRedirectSourceForHistory): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::reloadWithOverrideEncoding): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::loadDifferentDocumentItem): * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::initializeItem): * Source/WebCore/loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): * Source/WebCore/loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource): * Source/WebCore/loader/cache/CachedResource.cpp: (WebCore::CachedResource::load): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setResponseInternal): (WebCore::CachedResource::responseReceived): * Source/WebCore/loader/cache/CachedResource.h: * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::splitFragmentIdentifierFromRequestURL): (WebCore::upgradeInsecureResourceRequestIfNeeded): (WebCore::CachedResourceRequest::removeFragmentIdentifierIfNeeded): * Source/WebCore/loader/cocoa/BundleResourceLoader.mm: (WebCore::BundleResourceLoader::loadResourceFromBundle): * Source/WebCore/page/RemoteFrame.h: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded const): * Source/WebCore/platform/ContextMenuItem.h: (WebCore::ContextMenuItem::setTitle): * Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm: (WebCore::NetworkExtensionContentFilter::willSendRequest): * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setURL): * Source/WebCore/platform/network/ResourceRequestBase.h: * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::m_isNull): * Source/WebCore/platform/network/ResourceResponseBase.h: * Source/WebCore/platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): * Source/WebCore/platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): * Source/WebKit/Shared/WebsitePoliciesData.cpp: (WebKit::WebsitePoliciesData::applyToDocumentLoader): * Source/WebKit/UIProcess/API/APIWebsitePolicies.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setCustomUserAgent): (WebKit::WebPageProxy::setCustomUserAgentInternal): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::applyWebsitePolicies): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadRequest): (WebKit::WebPage::loadData): (WebKit::WebPage::setUserAgent): (WebKit::WebPage::setUserAgentInternal): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/294915@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes