Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f30fb6dd8798f2980421df0ac0b91d39ab6accde
https://github.com/WebKit/WebKit/commit/f30fb6dd8798f2980421df0ac0b91d39ab6accde
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-05-17 (Sat, 17 May 2025)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
PDFPluginBase::countFindMatches() need not be virtual
https://bugs.webkit.org/show_bug.cgi?id=293175
rdar://151516865
Reviewed by Wenson Hsieh and Richard Robinson.
Both PDFPlugin and UnifiedPDFPlugin provide the same implementation for
this method, so lets devirtualize and define it in PDFPluginBase.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::countFindMatches): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::countFindMatches):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::countFindMatches): Deleted.
Canonical link: https://commits.webkit.org/295060@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
