Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 910863b50bd8fba56a32e02bc0dfdfb83de15818
https://github.com/WebKit/WebKit/commit/910863b50bd8fba56a32e02bc0dfdfb83de15818
Author: Alan Baradlay <[email protected]>
Date: 2025-05-23 (Fri, 23 May 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner.html
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderObject.cpp
Log Message:
-----------
[content-visibility] Column spanner stays visible in skipped subtree
https://bugs.webkit.org/show_bug.cgi?id=293470
Reviewed by Antti Koivisto.
1. In WebKit, column spanners are moved out of their original insertion
position and get reparented under the column container.
2. "is this renderer inside a skipped subtree" logic consults parent state.
Now the parent of a column spanner (#1) may be completely outside of 'c-v: h'
tricking us into believing the spanner is not hidden.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-hidden-with-column-spanner.html:
Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChild):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChildren):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::isColumnSpanner const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::isSkippedContent const):
Canonical link: https://commits.webkit.org/295335@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
