Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 404b97e5c7727ac33edefbeb7cfebb0573fa04d9
https://github.com/WebKit/WebKit/commit/404b97e5c7727ac33edefbeb7cfebb0573fa04d9
Author: Devin Rousso <[email protected]>
Date: 2025-05-23 (Fri, 23 May 2025)
Changed paths:
M Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
M Source/WebInspectorUI/UserInterface/Models/ScriptTimeline.js
M Source/WebInspectorUI/UserInterface/Models/Timeline.js
M Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js
M Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js
M Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js
M Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
Log Message:
-----------
Web Inspector: REGRESSION(?): Timelines: Call Trees of Page target sometimes
aren't shown
https://bugs.webkit.org/show_bug.cgi?id=293469
Reviewed by BJ Burg.
* Source/WebInspectorUI/UserInterface/Models/ScriptTimeline.js:
(WI.ScriptTimeline.prototype.refresh): Added.
(WI.ScriptTimeline.prototype.callingContextTree):
* Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js:
(WI.ScriptProfileTimelineView):
(WI.ScriptProfileTimelineView.prototype.closed):
(WI.ScriptProfileTimelineView.prototype._callingContextTreeForOrientation):
(WI.ScriptProfileTimelineView.prototype._handleScriptTimelineTargetAdded):
Renamed from `_scriptTimelineRecordRefreshed`.
If the `WI.ScriptTimeline` doesn't have any `WI.Target`, it will instead use a
temporary `WI.CallingContextTree` with the `WI.mainTarget`.
This means that `WI.ProfileView` created for it won't have any data
`WI.ScriptTimeline.prototype.updateCallingContextTrees` won't affect it.
In this case, listen for `WI.ScriptTimeline.Event.TargetAdded` to see when the
`WI.Target` is finally added to the `WI.ScriptTimeline` to recreate the above.
If the `WI.mainTarget` is never added to the `WI.ScriptTimeline` then it'll
instead fallback to the first `WI.Target` added (see
`WI.ScriptClusterTimelineView.prototype._handleTargetAdded`).
* Source/WebInspectorUI/UserInterface/Models/Timeline.js:
(WI.Timeline.prototype.refresh): Deleted.
* Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js:
(WI.ScriptDetailsTimelineView):
(WI.ScriptDetailsTimelineView.prototype.closed):
(WI.ScriptDetailsTimelineView.prototype._handleScriptTimelineRefreshed):
Renamed from `_scriptTimelineRecordRefreshed`.
Drive-by: move the dispatch of `WI.Timeline.Event.Refreshed` to the subclass
`WI.ScriptTimeline` since that's where it's used.
* Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js:
(WI.ScriptClusterTimelineView.prototype._handleTargetAdded):
Drive-by: fix an incorrect assertion.
* Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView.prototype._recordingReset):
Drive-by: prevent an assertion failure.
* Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype.scriptProfilerTrackingCompleted):
Drive-by: add an extra assertion just in case.
Canonical link: https://commits.webkit.org/295373@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
