Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ef3b9deb58153642424424f1d1a1f3083cdc3af8
https://github.com/WebKit/WebKit/commit/ef3b9deb58153642424424f1d1a1f3083cdc3af8
Author: Geoffrey Garen <[email protected]>
Date: 2025-05-23 (Fri, 23 May 2025)
Changed paths:
M Source/WTF/wtf/CheckedArithmetic.h
M Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h
Log Message:
-----------
Fix the BUILD_WEBKIT_OPTIONS="--webGpuSwift" build in main
https://bugs.webkit.org/show_bug.cgi?id=293509
rdar://151945915
Reviewed by Mike Wyrzykowski.
The Swift-clang importer is complaining about:
* ambiguity in conversion of 'Checked<unsigned long, Checked<unsigned int,
CrashOnOverflow>>' to 'int'
* 'Checked<unsigned long, WTF::Checked<unsigned int>>' is not literal
because it is not an aggregate and has no constexpr constructors other than
copy or move constructors
I don't fully understand these complaints, and I'm not certain why Swift-clang
behaves differently from clang itself, within a given toolchain.
That said, I just did what the complaints said and then they went away.
* Source/WTF/wtf/CheckedArithmetic.h:
(WTF::Checked::Checked): Say 'contexpr' because the compiler has a sad when you
don't, and these functions do, in fact, appear to be constexpr.
* Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h:
(WebGPU_Internal::roundUpToMultipleOfNonPowerOfTwoCheckedUInt32UnsignedLong):
Avoid explicit template arguments because they're redundant and I think they had
the wrong types anyway.
Canonical link: https://commits.webkit.org/295383@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
