Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a518f208fde570152037786aead6b654c1840f0
      
https://github.com/WebKit/WebKit/commit/8a518f208fde570152037786aead6b654c1840f0
  Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com>
  Date:   2025-06-02 (Mon, 02 Jun 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/fast/forms/HTMLOptionElement_label03-expected.html
    R LayoutTests/fast/forms/HTMLOptionElement_label03.html
    M Source/WebCore/html/HTMLOptionElement.cpp

  Log Message:
  -----------
  `option` element should not trim label value
https://bugs.webkit.org/show_bug.cgi?id=292994
rdar://151309514

Reviewed by Aditya Keerthi.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

This patch removes the case where we were trimming label attribute value
for any leading and trailing whitespace.

While web specification [1] does not state any such thing:

[1] 
https://html.spec.whatwg.org/multipage/form-elements.html#concept-option-label

"The label of an option element is the value of the label content attribute,
if there is one and its value is not the empty string, or, otherwise,
the value of the element's text IDL attribute."

Similarly, following issue was also raised to clarify behavior and relevant
WPT tests were added [2], which we now progress with this patch:

[2] https://github.com/whatwg/html/issues/10955

* LayoutTests/TestExpectations:
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::label const):

> Removed in favor of WPT test:
* LayoutTests/fast/forms/HTMLOptionElement_label03-expected.html: Removed.
* LayoutTests/fast/forms/HTMLOptionElement_label03.html: Removed.

Canonical link: https://commits.webkit.org/295708@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to