Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7dc1ce0a8e8a58ffe0c41fa433c86044edf7e4a5
https://github.com/WebKit/WebKit/commit/7dc1ce0a8e8a58ffe0c41fa433c86044edf7e4a5
Author: Kiara Rose <[email protected]>
Date: 2025-06-06 (Fri, 06 Jun 2025)
Changed paths:
M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h
M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITest.mm
Log Message:
-----------
browser.test.runTests should move onto the next test if an assertion fails
https://bugs.webkit.org/show_bug.cgi?id=293404
rdar://150778809
Reviewed by Timothy Hatcher.
If we're running a test via browser.test.runTests, throw an exception if a test
assertion
fails to force the test to stop running.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm:
(WebKit::WebExtensionAPITest::fail):
(WebKit::WebExtensionAPITest::succeed):
(WebKit::WebExtensionAPITest::assertTrue):
(WebKit::WebExtensionAPITest::assertFalse):
(WebKit::WebExtensionAPITest::assertDeepEq):
(WebKit::WebExtensionAPITest::assertEquals):
(WebKit::WebExtensionAPITest::assertEq):
Modify these methods to raise an exception.
(WebKit::WebExtensionAPITest::assertRejects):
Drive by fix: Call the rejectCallback if the promise resolves for assertRejects.
(WebKit::WebExtensionAPITest::assertThrows):
(WebKit::WebExtensionAPITest::startNextTest):
(WebKit::WebExtensionAPITest::recordAssertionIfNeeded):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h:
(WebKit::WebExtensionAPITest::recordAssertionIfNeeded): Deleted.
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITest, RunTestsVerifyFailedTestAborts)):
Canonical link: https://commits.webkit.org/295926@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
