Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e50c61a139e343cc6e6611510f6490e05b12e3c5
https://github.com/WebKit/WebKit/commit/e50c61a139e343cc6e6611510f6490e05b12e3c5
Author: Simon Fraser <[email protected]>
Date: 2025-06-16 (Mon, 16 Jun 2025)
Changed paths:
M Source/WebCore/page/FrameView.cpp
M Source/WebCore/page/FrameView.h
M Source/WebCore/platform/ScrollView.cpp
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/Scrollbar.cpp
M Source/WebCore/platform/Scrollbar.h
M Source/WebCore/platform/Widget.cpp
M Source/WebCore/platform/Widget.h
M Source/WebCore/platform/ios/WidgetIOS.mm
M Source/WebCore/platform/mac/WidgetMac.mm
Log Message:
-----------
Clean up and extend the Widget coordinate conversion functions
https://bugs.webkit.org/show_bug.cgi?id=294530
rdar://153473471
Reviewed by Alan Baradlay.
A future change will require `convertFromRootToContainingWindow()` and
`convertFromContainingWindowToRoot()`
which support FloatPoint, so add `Widget::convert*` variants for
FloatPoint/FloatRect.
Also clean up the declarations and the definitions; order consistently by
function then type
(IntPoint, FloatPoint, IntRect, FloatRect).
Pass IntPoint and FloatPoint arguments by value.
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::convertFromRendererToContainingView const):
(WebCore::FrameView::convertFromContainingViewToRenderer const):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::viewToContents const):
(WebCore::ScrollView::windowToContents const):
(WebCore::ScrollView::contentsToWindow const):
(WebCore::ScrollView::convertSelfToChild const):
* Source/WebCore/platform/ScrollView.h:
* Source/WebCore/platform/Scrollbar.cpp:
(WebCore::Scrollbar::convertToContainingView const):
(WebCore::Scrollbar::convertFromContainingView const):
* Source/WebCore/platform/Scrollbar.h:
* Source/WebCore/platform/Widget.cpp:
(WebCore::Widget::convertToRootView const):
(WebCore::Widget::convertFromRootView const):
(WebCore::Widget::convertToContainingWindow const):
(WebCore::Widget::convertFromContainingWindow const):
(WebCore::Widget::convertToContainingView const):
(WebCore::Widget::convertFromContainingView const):
(WebCore::Widget::convertFromRootToContainingWindow):
(WebCore::Widget::convertFromContainingWindowToRoot):
* Source/WebCore/platform/Widget.h:
* Source/WebCore/platform/ios/WidgetIOS.mm:
(WebCore::Widget::convertFromRootToContainingWindow):
(WebCore::Widget::convertFromContainingWindowToRoot):
* Source/WebCore/platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromRootToContainingWindow):
(WebCore::Widget::convertFromContainingWindowToRoot):
Canonical link: https://commits.webkit.org/296272@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
