Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 95ed1aab1df31fbc852a890436729cab2414715a
https://github.com/WebKit/WebKit/commit/95ed1aab1df31fbc852a890436729cab2414715a
Author: Aditya Keerthi <[email protected]>
Date: 2025-06-23 (Mon, 23 Jun 2025)
Changed paths:
A
LayoutTests/fast/forms/number/number-min-max-spinbutton-appearance-none-crash-expected.txt
A
LayoutTests/fast/forms/number/number-min-max-spinbutton-appearance-none-crash.html
M Source/WebCore/html/NumberInputType.cpp
Log Message:
-----------
REGRESSION (296172@main): Crash when searching for products on lowes.com
https://bugs.webkit.org/show_bug.cgi?id=294857
rdar://153989680
Reviewed by Abrar Rahman Protyasha.
296172@main introduced an unconditional optional dereference in
`NumberInputType::decorationWidth`, when obtaining the width of the spin button.
The logic in that method has never worked correctly for non-fixed values. It
only runs when autosizing number inputs based on their min/max values. For now,
restore the original behavior by safely dereferencing the optional.
https://webkit.org/b/294858 has been filed to track a longer term solution.
*
LayoutTests/fast/forms/number/number-min-max-spinbutton-appearance-none-crash-expected.txt:
Added.
*
LayoutTests/fast/forms/number/number-min-max-spinbutton-appearance-none-crash.html:
Added.
* Source/WebCore/html/NumberInputType.cpp:
(WebCore::NumberInputType::decorationWidth const):
Percentage values are also checked to restore the old behavior.
Canonical link: https://commits.webkit.org/296537@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
