Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6165a0388d37476830fa346aef6b78d2aa5c91f4
https://github.com/WebKit/WebKit/commit/6165a0388d37476830fa346aef6b78d2aa5c91f4
Author: Anil Hebbar <[email protected]>
Date: 2025-06-26 (Thu, 26 Jun 2025)
Changed paths:
A LayoutTests/fast/css/vertical-align-rem-on-root-expected.txt
A LayoutTests/fast/css/vertical-align-rem-on-root.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/style/StyleBuilderCustom.h
Log Message:
-----------
ssue caused by vertical-align on root node with rem/rex type
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114
Reviewed by Sam Weinig.
Issue caused by vertical-align on root node with rem/rex type
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114
Reviewed by Sam Weinig.
The issue is when doing vertical-align of type rem or rex, it is assumed that
there
is a valid root style. This is not so in case of root node and this was causing
issues (root style is NULL ofr root element).
The fix was built over the following PR:
https://github.com/WebKit/WebKit/pull/46917.
The usage of new BuilderConverter::convertLength as opposed to
builderState.cssToLengthConversionData in function
BuilderCustom::applyValueVerticalAlign fixed the issue combined with the earlier
changes fixed the issue
Canonical link: https://commits.webkit.org/296678@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
