Diff
Modified: trunk/LayoutTests/ChangeLog (112910 => 112911)
--- trunk/LayoutTests/ChangeLog 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/LayoutTests/ChangeLog 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1,3 +1,17 @@
+2012-04-02 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r112851.
+ http://trac.webkit.org/changeset/112851
+ https://bugs.webkit.org/show_bug.cgi?id=82915
+
+ Broke 3 Mac accessibility tests (Requested by enrica on
+ #webkit).
+
+ * accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
+ * accessibility/anchor-link-selection-and-focus.html: Removed.
+ * platform/chromium/test_expectations.txt:
+ * platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
+
2012-04-02 Stephen Chenney <schen...@chromium.org>
<img style='width: 100%' src=''> gets pixellated when stretched
Deleted: trunk/LayoutTests/accessibility/anchor-link-selection-and-focus-expected.txt (112910 => 112911)
--- trunk/LayoutTests/accessibility/anchor-link-selection-and-focus-expected.txt 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/LayoutTests/accessibility/anchor-link-selection-and-focus-expected.txt 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1,19 +0,0 @@
-A link pointing to an anchor at the end of the document
-
-A paragraph with a some text in the middle
-
-The Anchor
-
-This tests that the caret position is properly updated when following anchor links.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-axLink.role is: 'AXRole: AXLink'
-axAnchor.role is: 'AXRole: AXLink'
-PASS axLink.isFocused is true
-PASS axAnchor.isFocused is false
-PASS getSelection().anchorNode.nodeValue is 'The Anchor'
-PASS axLink.isFocused is false
-PASS axAnchor.isFocused is true
-
Deleted: trunk/LayoutTests/accessibility/anchor-link-selection-and-focus.html (112910 => 112911)
--- trunk/LayoutTests/accessibility/anchor-link-selection-and-focus.html 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/LayoutTests/accessibility/anchor-link-selection-and-focus.html 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1,53 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<link rel="stylesheet" href=""
-<script>
-var successfullyParsed = false;
-</script>
-<script src=""
-</head>
-<body id="body">
-<p><a id="link" href="" link pointing to an anchor at the end of the document</a></p>
-<p>A paragraph with a some text in the middle</p>
-<p><a id="anchor" name="anchor" href="" Anchor</a></p>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-description("This tests that the caret position is properly updated when following anchor links.");
-
-if (window.layoutTestController) {
- layoutTestController.dumpAsText();
-
- if (window.accessibilityController) {
- var link = document.getElementById("link");
- var anchor = document.getElementById("anchor");
-
- // Get needed objects.
- link.focus();
- var axLink = accessibilityController.focusedElement;
- debug("axLink.role is: '" + axLink.role + "'");
- anchor.focus();
- var axAnchor = accessibilityController.focusedElement;
- debug("axAnchor.role is: '" + axAnchor.role + "'");
-
- // Focus on the link and check initial state.
- link.focus();
- shouldBe("axLink.isFocused", "true");
- shouldBe("axAnchor.isFocused", "false");
-
- // Execute action and check state.
- axLink.press()
-
- // Check final state.
- shouldBe("getSelection().anchorNode.nodeValue", "'The Anchor'");
- shouldBe("axLink.isFocused", "false");
- shouldBe("axAnchor.isFocused", "true");
- }
-}
-
-successfullyParsed = true;
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112910 => 112911)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1279,7 +1279,6 @@
BUGCR10322 SKIP : platform/mac/accessibility = PASS FAIL
BUGCR10322 SKIP : platform/win/accessibility = PASS FAIL
-BUGCR10322 SKIP : accessibility/anchor-link-selection-and-focus.html = TEXT
BUGCR10322 SKIP : accessibility/aria-activedescendant-crash.html = TEXT
BUGCR10322 SKIP : accessibility/aria-combobox.html = TEXT
BUGCR10322 SKIP : accessibility/aria-controls-with-tabs.html = TEXT
Deleted: trunk/LayoutTests/platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt (112910 => 112911)
--- trunk/LayoutTests/platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/LayoutTests/platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1,19 +0,0 @@
-A link pointing to an anchor at the end of the document
-
-A paragraph with a some text in the middle
-
-The Anchor
-
-This tests that the caret position is properly updated when following anchor links.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-axLink.role is: 'AXRole: link'
-axAnchor.role is: 'AXRole: link'
-PASS axLink.isFocused is true
-PASS axAnchor.isFocused is false
-PASS getSelection().anchorNode.nodeValue is 'The Anchor'
-PASS axLink.isFocused is false
-PASS axAnchor.isFocused is true
-
Modified: trunk/Source/WebCore/ChangeLog (112910 => 112911)
--- trunk/Source/WebCore/ChangeLog 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/Source/WebCore/ChangeLog 2012-04-02 18:15:33 UTC (rev 112911)
@@ -1,3 +1,20 @@
+2012-04-02 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r112851.
+ http://trac.webkit.org/changeset/112851
+ https://bugs.webkit.org/show_bug.cgi?id=82915
+
+ Broke 3 Mac accessibility tests (Requested by enrica on
+ #webkit).
+
+ * accessibility/AXObjectCache.cpp:
+ * accessibility/gtk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::handleScrolledToAnchor):
+ (WebCore):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::handleScrolledToAnchor):
+ (WebCore):
+
2012-04-02 Michael Saboff <msab...@apple.com>
WebKit should throttle memory pressure notifications in proportion to handler time
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (112910 => 112911)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2012-04-02 18:15:33 UTC (rev 112911)
@@ -54,7 +54,6 @@
#include "Document.h"
#include "FocusController.h"
#include "Frame.h"
-#include "FrameSelection.h"
#include "HTMLAreaElement.h"
#include "HTMLImageElement.h"
#include "HTMLInputElement.h"
@@ -72,8 +71,7 @@
#include "RenderTableRow.h"
#include "RenderView.h"
#include "ScrollView.h"
-#include "TextAffinity.h"
-#include "htmlediting.h"
+
#include <wtf/PassRefPtr.h>
namespace WebCore {
@@ -158,31 +156,6 @@
return obj;
}
-#if HAVE(ACCESSIBILITY) && (PLATFORM(MAC) || PLATFORM(GTK))
-void AXObjectCache::handleScrolledToAnchor(const Node* node)
-{
- ASSERT(node);
-
- Document* document = node->document();
- if (!document)
- return;
-
- RefPtr<Node> refNode = const_cast<Node*>(node);
- document->setFocusedNode(refNode);
-
- Frame* frame = document->frame();
- if (!frame)
- return;
-
- FrameSelection* selection = frame->selection();
- if (!selection)
- return;
-
- Position targetPosition = firstPositionInOrBeforeNode(refNode.get());
- selection->moveTo(targetPosition, DOWNSTREAM);
-}
-#endif
-
AccessibilityObject* AXObjectCache::get(Widget* widget)
{
if (!widget)
Modified: trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp (112910 => 112911)
--- trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-04-02 18:15:33 UTC (rev 112911)
@@ -231,4 +231,8 @@
}
}
+void AXObjectCache::handleScrolledToAnchor(const Node*)
+{
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (112910 => 112911)
--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2012-04-02 18:13:37 UTC (rev 112910)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2012-04-02 18:15:33 UTC (rev 112911)
@@ -144,6 +144,10 @@
wkAccessibilityHandleFocusChanged();
}
+void AXObjectCache::handleScrolledToAnchor(const Node*)
+{
}
+}
+
#endif // HAVE(ACCESSIBILITY)