Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a4508b65f711bf324f1a2868ed258d60112b4eb
      
https://github.com/WebKit/WebKit/commit/5a4508b65f711bf324f1a2868ed258d60112b4eb
  Author: Lily Spiniolas <lily_spinio...@apple.com>
  Date:   2025-07-03 (Thu, 03 Jul 2025)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/button-author-level-padding-applies-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/button-author-level-padding-applies.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/select-author-level-padding-applies-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/select-author-level-padding-applies.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm

  Log Message:
  -----------
  [Form Control Refresh] Author-specified padding on a <button> is being ignored
https://bugs.webkit.org/show_bug.cgi?id=295355
rdar://154889296

Reviewed by Aditya Keerthi.

Check if the author has explicitly set padding for native controls before 
applying
padding in RenderThemeCocoa.

Tested by button-author-level-padding-applies.html and
select-author-level-padding-applies.html.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/button-author-level-padding-applies-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/button-author-level-padding-applies.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/select-author-level-padding-applies-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/select-author-level-padding-applies.html:
 Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::applyPaddingIfNotExplicitlySet):
(WebCore::RenderThemeCocoa::adjustColorWellSwatchWrapperStyleForVectorBasedControls
 const):
(WebCore::applyEmPadding):
(WebCore::applyEmPaddingForNumberField):
(WebCore::RenderThemeCocoa::adjustTextFieldStyleForVectorBasedControls const):
(WebCore::applyCommonButtonPaddingToStyleForVectorBasedControls):
(WebCore::adjustSelectListButtonStyleForVectorBasedControls):
(WebCore::adjustInputElementButtonStyleForVectorBasedControls):
(WebCore::RenderThemeCocoa::adjustButtonStyleForVectorBasedControls const):

Canonical link: https://commits.webkit.org/297013@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to