Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 90da1bac176f6018de9d1ded7482bda821aa8e45
https://github.com/WebKit/WebKit/commit/90da1bac176f6018de9d1ded7482bda821aa8e45
Author: Alex Christensen <[email protected]>
Date: 2025-07-08 (Tue, 08 Jul 2025)
Changed paths:
M Source/WebKit/Shared/JavaScriptEvaluationResult.cpp
M Source/WebKit/Shared/JavaScriptEvaluationResult.h
M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
Log Message:
-----------
Remove unnecessary ObjC object instantiation in JavaScriptEvaluationResult
conversion to JSValueRef
https://bugs.webkit.org/show_bug.cgi?id=291116
rdar://148630517
Reviewed by Ryosuke Niwa.
This not only removes unnecessary work in the conversion process, but it also
makes the code
able to be used on platforms that don't have ObjC.
Covered by many tests, especially AsyncFunction API tests and
EvaluateJavaScript.ReturnTypes.
* Source/WebKit/Shared/JavaScriptEvaluationResult.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WTF::DefaultHash<JSC::Strong<JSC::JSCell>>::hash):
(WTF::DefaultHash<JSC::Strong<JSC::JSCell>>::equal):
(WebKit::JavaScriptEvaluationResult::toVariant):
(WebKit::JavaScriptEvaluationResult::addObjectToMap):
(WebKit::JavaScriptEvaluationResult::JavaScriptEvaluationResult):
(WebKit::JavaScriptEvaluationResult::toJS):
(WebKit::JavaScriptEvaluationResult::jsValueToVariant): Deleted.
Canonical link: https://commits.webkit.org/297138@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes