Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8b6851d5e38faa5cc08b07d6a98f38a33dc786f
      
https://github.com/WebKit/WebKit/commit/c8b6851d5e38faa5cc08b07d6a98f38a33dc786f
  Author: Ada Chan <[email protected]>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp

  Log Message:
  -----------
  [Model Element] Crash under WebModelPlayerProvider::deleteModelPlayer
https://bugs.webkit.org/show_bug.cgi?id=295602
rdar://154565882

Reviewed by Mike Wyrzykowski.

There's a possibility that WebPage::corePage() is null by the time
WebModelPlayerProvider::deleteModelPlayer() is called when cached
pages are being cleaned up in the BackForwardCache. We should check
it for null before dereferencing it to get its settings.

* Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp:
(WebKit::WebModelPlayerProvider::createModelPlayer):
Add a similar null check here before calling settings() on the
result of WebPage::corePage().
(WebKit::WebModelPlayerProvider::deleteModelPlayer):

Canonical link: https://commits.webkit.org/297141@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to