Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c80b2fa8587181f15a06cbe0ccc1414d3831321b
      
https://github.com/WebKit/WebKit/commit/c80b2fa8587181f15a06cbe0ccc1414d3831321b
  Author: Charlie Wolfe <[email protected]>
  Date:   2025-07-23 (Wed, 23 Jul 2025)

  Changed paths:
    M Source/WebCore/dom/DocumentStorageAccess.cpp

  Log Message:
  -----------
  `requestStorageAccess()` should always grant access when called from a 
same-site iframe
https://bugs.webkit.org/show_bug.cgi?id=296406
rdar://156545395

Reviewed by Matthew Finkel.

292862@main disabled automatic storage access for ABA iframes, but access 
should still be automatically
granted after requestStorageAccess() is called. 
requestStorageAccessQuickCheck() cannot return
StorageAccessQuickResult::Grant in this case, since access needs to be recorded 
for that iframe.

This change makes 3 out of 4 subtests in 
requestStorageAccess-ABA.sub.https.window.html pass. Not covered
in WKTR due to the lack of a local DNS resolver.

* Source/WebCore/dom/DocumentStorageAccess.cpp:
(WebCore::hasSameOriginAsAllAncestors):
(WebCore::DocumentStorageAccess::hasStorageAccessQuickCheck):
(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):
(WebCore::hasSameOrigin): Deleted.

Canonical link: https://commits.webkit.org/297818@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to