Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 755b208ecfa8021bbedc5b312397af010e87f6ee
https://github.com/WebKit/WebKit/commit/755b208ecfa8021bbedc5b312397af010e87f6ee
Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com>
Date: 2025-07-28 (Mon, 28 Jul 2025)
Changed paths:
A LayoutTests/fast/repaint/table-with-padding-row-invalidation-expected.txt
A LayoutTests/fast/repaint/table-with-padding-row-invalidation.html
M
LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-expected.txt
M
LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt
M
LayoutTests/platform/ios/fast/table/table-in-table-percent-width-collapsing-border-expected.txt
M
LayoutTests/platform/ios/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableInlines.h
Log Message:
-----------
Collapsing borders disallow padding on table
https://bugs.webkit.org/show_bug.cgi?id=295479
rdar://problem/155693380
Reviewed by Alan Baradlay.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/a489de4b9d41cb02aac1e52a2d3e367fdab31a17
This patch fixes bug where we would wrongly remove the padding from the
available space for table-row-group and table-row when collapsing borders.
CSS [1] is clear that paddings are not allowed on table with collapsing
borders.
[1] https://www.w3.org/TR/CSS2/tables.html#collapsing-borders
"Also, in this model, a table does not have padding..."
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableInlines.h:
(WebCore::RenderTable::paddingTop const):
(WebCore::RenderTable::paddingBottom const):
(WebCore::RenderTable::paddingLeft const):
(WebCore::RenderTable::paddingRight const):
(WebCore::RenderTable::paddingAfter const):
(WebCore::RenderTable::paddingBefore const):
(WebCore::RenderTable::paddingStart const):
(WebCore::RenderTable::paddingEnd const):
* LayoutTests/fast/repaint/table-with-padding-row-invalidation.html:
* LayoutTests/fast/repaint/table-with-padding-row-invalidation-expected.txt:
> Rebaselines:
*
LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-expected.txt:
*
LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt:
*
LayoutTests/platform/ios/fast/table/table-in-table-percent-width-collapsing-border-expected.txt:
*
LayoutTests/platform/ios/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt:
Canonical link: https://commits.webkit.org/297946@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
