Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02a339f40c687d1ce5b504eea903ab94cf8b40ca
      
https://github.com/WebKit/WebKit/commit/02a339f40c687d1ce5b504eea903ab94cf8b40ca
  Author: Sammy Gill <sammy.g...@apple.com>
  Date:   2025-08-14 (Thu, 14 Aug 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox_first-letter-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/getcomputedstyle/first-line-computed-style-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/getcomputedstyle/first-line-computed-style.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/style/StyleTreeResolver.cpp
    M Source/WebCore/style/StyleTreeResolver.h

  Log Message:
  -----------
  [Flex] getComputedStyle should reflect that first-letter and first-line 
cannot be applied to flexboxes.
https://bugs.webkit.org/show_bug.cgi?id=210474
rdar://94163778

Reviewed by Tim Nguyen.

first-letter and first-line cannot be applied to flexboxes since these
boxes do not generate a first formatted line. However, if you attempt to
query the respective pseudo element's style via getComputedStyle you
will end up with the value that was specified even though it should not
have been applied.

(WebCore::Document::styleForElementIgnoringPendingStylesheets):
Instead of just trying to resolve the style for the pseudo element
immediately, we should first resolve the style with the associated
element and check whether or not it can have the associated pseudo
content.

Canonical link: https://commits.webkit.org/298706@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to