Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f22f095d4f9c6b863ce805bfb8e6faf9adf80efc
      
https://github.com/WebKit/WebKit/commit/f22f095d4f9c6b863ce805bfb8e6faf9adf80efc
  Author: Adrian Perez de Castro <ape...@igalia.com>
  Date:   2025-08-15 (Fri, 15 Aug 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] Use gst_device_reconfigure_element() to configure audio outputs
https://bugs.webkit.org/show_bug.cgi?id=297418

Reviewed by Philippe Normand.

Instead of relying on knowledge about how different GStreamer elements
handle the choice of output device, use gst_device_reconfigure_element()
instead.

This also makes applyAudioSinkDevice() function work with elements which
are not bins. Previously it assumed that the passed element would always
be a bin, which would prevent switching audio outputs correctly when
MediaPlayerPrivateGStreamer::audioSink() returns a non-bin element.

While at it, sprinkle some debug logging and turn applyAudioSinkDevice()
into a method to allow doing so.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::applyAudioSinkDevice):
(WebCore::MediaPlayerPrivateGStreamer::audioOutputDeviceChanged):
(WebCore::applyAudioSinkDevice): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/298747@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to