Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fccd92e3da0195681cd6f07e33366e1716e95fe2
https://github.com/WebKit/WebKit/commit/fccd92e3da0195681cd6f07e33366e1716e95fe2
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-08-22 (Fri, 22 Aug 2025)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebKit/Headers.cmake
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/Shared/API/c/WKBase.h
A Source/WebKit/Shared/JSHandleInfo.cpp
M Source/WebKit/Shared/JSHandleInfo.h
M Source/WebKit/Shared/JavaScriptEvaluationResult.cpp
M Source/WebKit/Shared/JavaScriptEvaluationResult.h
M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
M Source/WebKit/Shared/JavaScriptEvaluationResult.serialization.in
M Source/WebKit/Shared/NodeHitTestResult.h
M Source/WebKit/Shared/NodeHitTestResult.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/UIProcess/API/C/WKAPICast.h
A Source/WebKit/UIProcess/API/C/WKJSHandleRef.cpp
A Source/WebKit/UIProcess/API/C/WKJSHandleRef.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKJSHandle.h
M Source/WebKit/UIProcess/API/Cocoa/_WKJSHandle.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
Log Message:
-----------
Add WKFrameInfo accessor to _WKJSHandle
https://bugs.webkit.org/show_bug.cgi?id=297745
rdar://158885679
Reviewed by Ryosuke Niwa.
A _WKJSHandle can't be used for much without using a WKFrameInfo, and it has to
be the correct
WKFrameInfo, so before this change we always needed to keep the pair of objects
together.
This makes the API a little more ergonomic by adding a frame accessor so you
only need to keep
one object in a container and can use it.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::frameID const): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::frameID const):
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Shared/API/c/WKBase.h:
* Source/WebKit/Shared/JSHandleInfo.cpp: Copied from
Source/WebKit/Shared/JSHandleInfo.h.
* Source/WebKit/Shared/JSHandleInfo.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.cpp:
(WebKit::JavaScriptEvaluationResult::APIInserter::toAPI):
(WebKit::JavaScriptEvaluationResult::APIExtractor::toValue):
(WebKit::JavaScriptEvaluationResult::JSExtractor::toValue):
(WebKit::JavaScriptEvaluationResult::JSInserter::toJS):
* Source/WebKit/Shared/JavaScriptEvaluationResult.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WebKit::JavaScriptEvaluationResult::ObjCInserter::toID):
(WebKit::JavaScriptEvaluationResult::ObjCExtractor::toValue):
* Source/WebKit/Shared/JavaScriptEvaluationResult.serialization.in:
* Source/WebKit/Shared/NodeHitTestResult.h:
* Source/WebKit/Shared/NodeHitTestResult.serialization.in:
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/API/C/WKAPICast.h:
* Source/WebKit/UIProcess/API/C/WKJSHandleRef.cpp: Copied from
Source/WebKit/Shared/JSHandleInfo.h.
(WKJSHandleGetTypeID):
(WKJSHandleCopyFrameInfo):
* Source/WebKit/UIProcess/API/C/WKJSHandleRef.h: Copied from
Source/WebKit/Shared/JSHandleInfo.h.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _hitTestAtPoint:inFrameCoordinateSpace:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKJSHandle.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKJSHandle.mm:
(-[_WKJSHandle frame]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::hitTestAtPoint):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hitTestAtPoint):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, HitTesting)):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::Callbacks::append):
(WTR::TestController::Callbacks::notifyListeners):
(WTR::CompletionHandler<void):
* Tools/WebKitTestRunner/TestController.h:
(WTR::TestController::Callbacks::append): Deleted.
Canonical link: https://commits.webkit.org/299058@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
