Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4f15a2dcb6026e5d20a185f1cc2c186729da425
      
https://github.com/WebKit/WebKit/commit/a4f15a2dcb6026e5d20a185f1cc2c186729da425
  Author: Simon Pena <sp...@igalia.com>
  Date:   2025-09-04 (Thu, 04 Sep 2025)

  Changed paths:
    M Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
    M Tools/WebKitTestRunner/libwpe/EventSenderProxyClientLibWPE.cpp
    M Tools/WebKitTestRunner/wpe/EventSenderProxyClientWPE.cpp

  Log Message:
  -----------
  [GTK][WPE] Minor EventSenderProxy refactoring
https://bugs.webkit.org/show_bug.cgi?id=297774

Reviewed by Adrian Perez de Castro.

Consolidate some of the EventSenderProxy repeated logic into helper
functions, including guarded code, for GTK, LibWPE and WPE.

* Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: created a helper
  function that abstracts the common key handling logic.
(WTR::processKeyEvent):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):
* Tools/WebKitTestRunner/libwpe/EventSenderProxyClientLibWPE.cpp:
  created a helper class to abstract event creation and destruction of
  helper resources.
(WTR::KeyboardEvent::KeyboardEvent):
(WTR::KeyboardEvent::~KeyboardEvent):
(WTR::KeyboardEvent::createInputKeyboardEvent):
(WTR::EventSenderProxyClientLibWPE::keyDown):
(WTR::EventSenderProxyClientLibWPE::rawKeyDown):
(WTR::EventSenderProxyClientLibWPE::rawKeyUp):
* Tools/WebKitTestRunner/wpe/EventSenderProxyClientWPE.cpp:
(WTR::applyKeyvalModifiers): extracted additional changes to modifiers
into a separate method.
(WTR::EventSenderProxyClientWPE::keyDown):
(WTR::EventSenderProxyClientWPE::rawKeyDown):

Canonical link: https://commits.webkit.org/299549@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to