Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 69ba6c5c05c01a0247bfbe0a9d845fb9b1b09ed6
https://github.com/WebKit/WebKit/commit/69ba6c5c05c01a0247bfbe0a9d845fb9b1b09ed6
Author: Abrar Rahman Protyasha <a_protya...@apple.com>
Date: 2025-09-10 (Wed, 10 Sep 2025)
Changed paths:
M Source/WebKit/Shared/mac/PDFContextMenu.h
M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[recoveryOS] [PDF] "Open with ..." context menu option does not work
https://bugs.webkit.org/show_bug.cgi?id=298678
rdar://160272535
Reviewed by Tim Horton.
This option expectedly does not work in recoveryOS, for multiple reasons.
In this patch, we choose to not present the option when appropriate.
There are a few more drive-by changes explained below.
* Source/WebKit/Shared/mac/PDFContextMenu.h:
* Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in:
Change "openInPreview" to "openInDefaultViewer". The former is a
misnomer even if Preview is the appropriate default viewer in most
cases.
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
The std::optional<T>::operator==(self, U value) overload automatically
returns false if the optional holds a `std::nullopt`, so we can elide
this emptiness check.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::isInRecoveryOS):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
Canonical link: https://commits.webkit.org/299824@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
