Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1d2530a18d24e4f56c87e4bcd3f3d716e944cca6
https://github.com/WebKit/WebKit/commit/1d2530a18d24e4f56c87e4bcd3f3d716e944cca6
Author: Geoffrey Garen <[email protected]>
Date: 2025-09-17 (Wed, 17 Sep 2025)
Changed paths:
M Configurations/CommonBase.xcconfig
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandsMixin.h
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/WebGPUExt.h
Log Message:
-----------
Remove all uses of PUBLIC_IN_WEBGPU_SWIFT
https://bugs.webkit.org/show_bug.cgi?id=299042
rdar://160803645
Reviewed by Mike Wyrzykowski and Elliott Williams.
PUBLIC_IN_WEBGPU_SWIFT was a glorious hack to enable implementing parts of a C++
class in Swift despite name lookup rules making private and protected members
invisible.
Now that rdar://137764620 is fixed, we can use SWIFT_PRIVATE_FILEID instead.
I consider this a subtask of removing un-safety in this code because making
private fields public is... not a great way to uphold essential invariants.
* Configurations/CommonBase.xcconfig: Enable SWIFT_PRIVATE_FILEID
* Source/WebGPU/WebGPU/Buffer.h: Use SWIFT_PRIVATE_FILEID instead of public.
* Source/WebGPU/WebGPU/CommandEncoder.h: Use SWIFT_PRIVATE_FILEID instead of
public.
* Source/WebGPU/WebGPU/CommandsMixin.h: Declare our enum public because it
doesn't hold any private state, and all subclasses inherit this class publicly
anyway. (Also, we can't support protected enum declarations until
rdar://160803362 is fixed.)
* Source/WebGPU/WebGPU/Device.h: No need for double `private` anymore since
there's no interstitial `public`.
(WebGPU::Device::nopVertexFunction const):
* Source/WebGPU/WebGPU/Queue.h: Use SWIFT_PRIVATE_FILEID instead of public.
* Source/WebGPU/WebGPU/WebGPUExt.h: No need for SWIFT_PRIVATE_FILEID anymore!
Canonical link: https://commits.webkit.org/300128@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
