Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fca0e1c9487d3b23f124549fe893650ac5924e7d
https://github.com/WebKit/WebKit/commit/fca0e1c9487d3b23f124549fe893650ac5924e7d
Author: Tim Horton <[email protected]>
Date: 2025-09-26 (Fri, 26 Sep 2025)
Changed paths:
M Tools/Scripts/hooks/prepare-commit-msg
M Tools/Scripts/prepare-ChangeLog
Log Message:
-----------
"No new tests" text is duplicated when amending a commit
https://bugs.webkit.org/show_bug.cgi?id=299557
rdar://161361290
Reviewed by Ryan Haddad.
When amending a commit, we re-run prepare-ChangeLog and merge the output.
The logic to do so was built with the expectation that prepare-ChangeLog
would only output the file listing, but this is not the case now that we
have repaired the test warning/listing.
In order to fix this, provide a separate switch to disable the test warning,
and adopt it when amending. Ideally, we'd update the test listing/warning state
based on the combined commit, but working out how to do that (since the test
listing
is pretty freeform) is well outside the scope of fixing this bug.
* Tools/Scripts/hooks/prepare-commit-msg:
Avoid duplication by disabling test mentions when amending.
* Tools/Scripts/prepare-ChangeLog:
(main):
(generateNewChangeLogs):
Add a knob to disable test mentions.
Canonical link: https://commits.webkit.org/300609@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
