Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 729d64bab05f34595cdb89f97889b354fdec8328
      
https://github.com/WebKit/WebKit/commit/729d64bab05f34595cdb89f97889b354fdec8328
  Author: Darin Adler <[email protected]>
  Date:   2025-09-27 (Sat, 27 Sep 2025)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Scripts/generate-unified-sources.sh
    M Source/JavaScriptCore/SourcesCocoa.txt
    M Source/JavaScriptCore/UnifiedSources-output.xcfilelist
    M Source/JavaScriptCore/inspector/remote/SourcesCocoa.txt
    M Source/WTF/Scripts/generate-unified-source-bundles.rb
    M Source/WebCore/Scripts/generate-unified-sources.sh
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/UnifiedSources-output.xcfilelist
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/Platform/SourcesCocoa.txt
    M Source/WebKit/Scripts/generate-unified-sources.sh
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UnifiedSources-output.xcfilelist
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm
    M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICookiesCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm
    M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm
    M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm
    M 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm
    M 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebRequestFilter.mm
    M Source/WebKitLegacy/SourcesCocoa.txt
    M Source/WebKitLegacy/UnifiedSources-output.xcfilelist
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/scripts/generate-unified-sources.sh
    M Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/UnifiedSources-output.xcfilelist

  Log Message:
  -----------
  Convert WebKit WebExtension ARC code to unified source compiling
rdar://160949824
https://bugs.webkit.org/show_bug.cgi?id=299190

Reviewed by Timothy Hatcher and Keith Miller.

Added support to make separate unified source files for ARC and non-ARC
Objective-C++ code. Used it in WebKit for extensions ARC code.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
Renamed unified source files to use -nonARC.mm suffix.

* Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
Update for new non-ARC category.

* Source/JavaScriptCore/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files.

* Source/JavaScriptCore/UnifiedSources-output.xcfilelist:
Renamed unified source files to use -nonARC.mm suffix.

* Source/JavaScriptCore/inspector/remote/SourcesCocoa.txt: Added
@nonARC to all the non-ARC Objective-C++ source files.

* Source/WTF/Scripts/generate-unified-source-bundles.rb: Added
support for separate ARC and non-ARC Objective-C++ sources.

* Source/WebCore/Scripts/generate-unified-sources.sh:
Update for new non-ARC category.

* Source/WebCore/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files.

* Source/WebCore/UnifiedSources-output.xcfilelist:
Renamed unified source files to use -nonARC.mm suffix.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Renamed unified source files to use -nonARC.mm suffix.

* Source/WebKit/Platform/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files.

* Source/WebKit/Scripts/generate-unified-sources.sh:
Update for new non-ARC category.

* Source/WebKit/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files. Added the WebExtensions
source files.

* Source/WebKit/UnifiedSources-output.xcfilelist:
Renamed unified source files to use -nonARC.mm suffix.
Added the new files with the -ARC.mm suffix.

* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Renamed unified source files to use -nonARC.mm suffix.
Added new unified source files with the -ARC.mm suffix.
Turned off compilation of all the individual WebExtension
source file that are now compiled in unified sources.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm:
(WebKit::toAPI):
(WebKit::WebExtensionContextProxy::dispatchCommandsChangedEvent):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICookiesCocoa.mm:
(WebKit::toWebAPI):
(WebKit::WebExtensionAPICookies::parseCookieDetails):
(WebKit::WebExtensionAPICookies::get):
(WebKit::WebExtensionAPICookies::set):
(WebKit::WebExtensionAPICookies::remove):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm:
(WebKit::WebExtensionAPIMenus::parseCreateAndUpdateProperties):
(WebKit::WebExtensionContextProxy::dispatchMenusClickedEvent):
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm:
(WebKit::toWebAPI):
(WebKit::WebExtensionAPIScripting::parseCSSInjectionOptions):
(WebKit::WebExtensionAPIScripting::parseRegisteredContentScripts):
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm:
(WebKit::webRequestDetailsForResourceLoad):
(WebKit::convertHeaderFieldsToWebExtensionFormat):
(WebKit::WebExtensionContextProxy::resourceLoadDidCompleteWithError):
* 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm:
(-[_WKWebExtensionWebNavigationURLFilter initWithDictionary:outErrorMessage:]):
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebRequestFilter.mm:
(-[_WKWebExtensionWebRequestFilter initWithDictionary:outErrorMessage:]):
(-[_WKWebExtensionWebRequestFilter _initializeWithDictionary:]):
Use @"" directly instead of named @"" constants to sidestep issue with
duplicate versions of the same string constant.

* Source/WebKitLegacy/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files.

* Source/WebKitLegacy/UnifiedSources-output.xcfilelist:
Renamed unified source files to use -nonARC.mm suffix.

* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
Renamed unified source files to use -nonARC.mm suffix.

* Source/WebKitLegacy/scripts/generate-unified-sources.sh:
Update for new non-ARC category.

* Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh:
Update for new non-ARC category.

* Tools/TestWebKitAPI/SourcesCocoa.txt: Added @nonARC to all the
non-ARC Objective-C++ source files.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Renamed unified source files to use -nonARC.mm suffix.

* Tools/TestWebKitAPI/UnifiedSources-output.xcfilelist:
Renamed unified source files to use -nonARC.mm suffix.

Canonical link: https://commits.webkit.org/300647@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to