Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 417f208ec5d85416e089fa61541f47a387b8c61b
      
https://github.com/WebKit/WebKit/commit/417f208ec5d85416e089fa61541f47a387b8c61b
  Author: Nipun Shukla <[email protected]>
  Date:   2025-10-02 (Thu, 02 Oct 2025)

  Changed paths:
    M LayoutTests/media/track/track-cue-css.html
    A LayoutTests/media/track/webvtt-parser-does-not-leak-expected.txt
    A LayoutTests/media/track/webvtt-parser-does-not-leak.html
    M Source/WebCore/html/track/WebVTTParser.cpp
    M Source/WebCore/html/track/WebVTTParser.h

  Log Message:
  -----------
  [World Leaks] Investigate leaks in 
LayoutTests/imported/w3c/web-platform-tests/webvtt/
https://bugs.webkit.org/show_bug.cgi?id=299220
rdar://160965639

Reviewed by Jer Noble.

WebVTTParser holds a strong const Ref<Document>. Changing this to a WeakRef
fixes approximately 300 leaky tests.

Test: media/track/webvtt-parser-does-not-leak.html

Test: media/track/webvtt-parser-does-not-leak.html
* LayoutTests/media/track/track-cue-css.html:
* LayoutTests/media/track/webvtt-parser-does-not-leak-expected.txt: Added.
* LayoutTests/media/track/webvtt-parser-does-not-leak.html: Added.
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::checkAndCreateRegion):
* Source/WebCore/html/track/WebVTTParser.h:

Canonical link: https://commits.webkit.org/300881@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to