Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9ee3842efc07b32297d302c6039c7c42f494816f
https://github.com/WebKit/WebKit/commit/9ee3842efc07b32297d302c6039c7c42f494816f
Author: Tadeu Zagallo <[email protected]>
Date: 2025-10-13 (Mon, 13 Oct 2025)
Changed paths:
M Source/WebGPU/WebGPU/CommandEncoder.swift
Log Message:
-----------
[WebGPU Swift] Fix crashing regression tests
https://bugs.webkit.org/show_bug.cgi?id=300510
rdar://162374042
Reviewed by Mike Wyrzykowski and Geoffrey Garen.
There were 8 crashing tests under fast/webgpu/nocrash caused by 3 separate small
bugs in CommandEncoder.swift:
- A call to Range using `(offset, size)` instead of `(start, end)`
- One remaining instance of `m_lastErrorString` being implicitly unwrapped when
it
was nil
- There was a bit of a confusion with the types used in `timestampWriteIndex`,
so I cleaned it up, but I believe the real issue was the definition of
`WGPU_MTLCounterDontSample` not matching `MTLCounterDontSample`. I'm not sure
why the latter wasn't used originally, but it seems to work now.
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(WebGPU.finish(_:)):
(WebGPU.timestampWriteIndex(_:)):
(WebGPU.beginRenderPass(_:)):
(WebGPU.beginComputePass(_:)):
Canonical link: https://commits.webkit.org/301396@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
