Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92c4111ec3f8005d00327d0c0d0a2465aa02f95b
https://github.com/WebKit/WebKit/commit/92c4111ec3f8005d00327d0c0d0a2465aa02f95b
Author: Kiara Rose <[email protected]>
Date: 2025-10-17 (Fri, 17 Oct 2025)
Changed paths:
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm
Log Message:
-----------
menus.create should use iconVariants key not icon_variants
https://bugs.webkit.org/show_bug.cgi?id=300404
rdar://problem/162225272
Reviewed by Timothy Hatcher.
To align with other JS APIs, we should use camelCase and not snake_case for
these keys.
Keep support for the old API keys to avoid breaking existing extensions. Filed
https://webkit.org/b/300927
to follow up with a full deprecation of these keys.
Tests: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::bestIconVariantJSONObject):
Check for both the manifest and API version of this key since this method is
used for both cases.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm:
(WebKit::WebExtensionAPIAction::parseIconPathsDictionary):
(WebKit::WebExtensionAPIAction::parseIconImageDataDictionary):
(WebKit::WebExtensionAPIAction::parseIconVariants):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm:
(WebKit::WebExtensionAPIMenus::parseCreateAndUpdateProperties):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SetIconWithVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SetIconWithImageDataAndVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIAction,
SetIconThrowsWithNoValidVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIAction,
SetIconWithMixedValidAndInvalidVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIAction,
SetIconWithAnySizeVariantAndSVGDataURL)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, CreateMenuWithDeprecatedKeys)):
Verify that the new API keys take precedent over the deprecated keys.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithIconVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithImageDataVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithWithNoValidVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithMixedValidAndInvalidIconVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithAnySizeVariantAndSVGDataURL)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, UpdateMenuItemWithIconVariants)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
ClearMenuItemIconVariantsWithNull)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
ClearMenuItemIconVariantsWithEmpty)):
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithSymbolImageIconVariants)):
Canonical link: https://commits.webkit.org/301718@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
