Title: [113443] trunk/Source/WebCore
- Revision
- 113443
- Author
- [email protected]
- Date
- 2012-04-06 09:04:51 -0700 (Fri, 06 Apr 2012)
Log Message
Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
https://bugs.webkit.org/show_bug.cgi?id=82616
Reviewed by Pavel Feldman.
- center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113442 => 113443)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 15:45:48 UTC (rev 113442)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 16:04:51 UTC (rev 113443)
@@ -1,3 +1,15 @@
+2012-04-06 Andrey Kosyakov <[email protected]>
+
+ Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
+ https://bugs.webkit.org/show_bug.cgi?id=82616
+
+ Reviewed by Pavel Feldman.
+
+ - center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
+
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
+
2012-04-06 Vineet Chaudhary <[email protected]>
Add CodeGenerator support for sequence<> in callbacks.
Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (113442 => 113443)
--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-04-06 15:45:48 UTC (rev 113442)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-04-06 16:04:51 UTC (rev 113443)
@@ -487,7 +487,11 @@
WebInspector.elementDragEnd(event);
var window = this._overviewWindowSelector._close(event.pageX - this._parentElement.offsetLeft);
delete this._overviewWindowSelector;
- if (window.end - window.start < WebInspector.TimelineOverviewPane.MinSelectableSize) {
+ if (window.end === window.start) { // Click, not drag.\
+ var middle = window.end;
+ window.start = Math.max(0, middle - WebInspector.TimelineOverviewPane.MinSelectableSize / 2);
+ window.end = Math.min(this._parentElement.clientWidth, middle + WebInspector.TimelineOverviewPane.MinSelectableSize / 2);
+ } else if (window.end - window.start < WebInspector.TimelineOverviewPane.MinSelectableSize) {
if (this._parentElement.clientWidth - window.end > WebInspector.TimelineOverviewPane.MinSelectableSize)
window.end = window.start + WebInspector.TimelineOverviewPane.MinSelectableSize;
else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
