Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7a0ecbe32e975658b4c41b2fe62d7ce1172c504
      
https://github.com/WebKit/WebKit/commit/c7a0ecbe32e975658b4c41b2fe62d7ce1172c504
  Author: Yusuke Suzuki <[email protected]>
  Date:   2025-09-29 (Mon, 29 Sep 2025)

  Changed paths:
    A JSTests/wasm/stress/omg-recompile-from-two-bbq.js
    M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp
    M Source/JavaScriptCore/wasm/WasmCalleeGroup.h
    M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp

  Log Message:
  -----------
  [JSC] Avoid reinstalling OMG
https://bugs.webkit.org/show_bug.cgi?id=299829
rdar://161555855

Reviewed by Yijia Huang.

After 299561@main, these installation are racily done. So there is a
chance that BBQ gets retried, reinstalled again and two OMG compilation
are on-the-fly. So the second OMG callee can be installed. For now,
let's make it more defensive. When OMG callee is already installed, make
the compilation failed.

Test: JSTests/wasm/stress/omg-recompile-from-two-bbq.js

* JSTests/wasm/stress/omg-recompile-from-two-bbq.js: Added.
(instantiate):
(async let):
* Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp:
(JSC::Wasm::CalleeGroup::releaseBBQCallee):
(JSC::Wasm::CalleeGroup::startInstallingCallee):
(JSC::Wasm::CalleeGroup::installOptimizedCallee):
* Source/JavaScriptCore/wasm/WasmCalleeGroup.h:
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):

Canonical link: https://commits.webkit.org/300735@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to