Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44bd78d54f85af0780656e0d1fd50e19586f89df
      
https://github.com/WebKit/WebKit/commit/44bd78d54f85af0780656e0d1fd50e19586f89df
  Author: Yulun Wu <[email protected]>
  Date:   2025-11-17 (Mon, 17 Nov 2025)

  Changed paths:
    A 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-4-expected.txt
    A 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-4.html
    A 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-5-expected.txt
    A 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-5.html
    M 
Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp

  Log Message:
  -----------
  [text-wrap][pretty] Fix incorrect index in InlineContentConstrainer 
hyphenation fallback
https://bugs.webkit.org/show_bug.cgi?id=302553
<rdar://164680038>

Reviewed by Alan Baradlay.

This PR fixes a bug where the hyphenation fallback was using the wrong
starting inline item position. We should use:

breakOpportunities[lastValidStateIndex]

to correctly look up the actual inline item index from
the break opportunities array.

This PR also adds bounds checks before accessing the arrays.

Combined changes:
* 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-4-expected.txt:
 Added.
* 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-4.html:
 Added.
* 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-5-expected.txt:
 Added.
* 
LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-5.html:
 Added.
* Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp:
(WebCore::Layout::InlineContentConstrainer::prettifyRange):

Canonical link: https://commits.webkit.org/303130@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to