Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f27a04372bba0b7947d9eb7fc2ab8e5d04de60a8
https://github.com/WebKit/WebKit/commit/f27a04372bba0b7947d9eb7fc2ab8e5d04de60a8
Author: Sam Weinig <[email protected]>
Date: 2025-11-18 (Tue, 18 Nov 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-computed-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-computed.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-invalid-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-invalid.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-valid-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-valid.html
M Source/WebCore/style/values/backgrounds/StyleBackgroundSize.cpp
Log Message:
-----------
REGRESSION (STP 232): comma-separated values for mask-size: auto gets unset
https://bugs.webkit.org/show_bug.cgi?id=302533
rdar://164727930
Reviewed by Tim Nguyen.
Fixes style building failure for `mask-size: auto`. The failure was due to
parsing code for `mask-size` using a single CSSPrimitiveValue as the specified
value representation for a single `auto` value, unlike `background-size`, which
always created a CSSValuePair with two identical CSSPrimitiveValues in that
case,
coupled with the lack of handling as single CSSPrimitiveValue in the
CSSValueConversion
code. The fix is simply to support a single CSSPrimitiveValue `auto` case.
There were also no parsing tests for `mask-size`, so the complete
valid/invalid/computed
set was added.
Tests:
imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-computed.html
imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-invalid.html
imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-valid.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-computed-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-computed.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-invalid-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-invalid.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-valid-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-size-valid.html:
Added.
* Source/WebCore/style/values/backgrounds/StyleBackgroundSize.cpp:
(WebCore::Style::CSSValueConversion<BackgroundSize>::operator):
Canonical link: https://commits.webkit.org/303192@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
